Re: [PATCH v5 03/12] dt-bindings: i2c: add bindings for microchip mpfs i2c

[Conor Dooley]

On 04/02/2022 22:45, Rob Herring wrote:
> On Mon, Jan 31, 2022 at 03:55:32PM +0000, Conor.Dooley@xxxxxxxxxxxxx wrote:
> > On 31/01/2022 15:39, Rob Herring wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > >
> > > On Mon, Jan 31, 2022 at 5:45 AM <conor.dooley@xxxxxxxxxxxxx> wrote:
> > > > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > > >
> > > > Add device tree bindings for the i2c controller on
> > > > the Microchip PolarFire SoC.
> > > >
> > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > >
> > > There should not be a blank line here.
> > >
> > > Also, tags should be in chronological order typically. If Daire sent
> > > this patch out with my tag, then the order is correct. If I gave it on
> > > a version you sent, then it goes between Daire's and your S-o-b which
> > > is the case here.
> > Oh, thanks. Probably been messing this up right/left/centre.
> >
> > On another note, I know I'm still missing a RB still on some of the
> > bindings, but what is the acceptance path for this series?
> > Any left over bindings not taken by subsystems via yourself and the dts
> > changes via Palmer's tree?
>
> They should go via subsystems. I can take if you want, but not with
> missing dependencies. I need my tree working.

I should just drop the dependency on the clock binding from the 
examples, not really much reason to have it there. Still a dep. for the 
device tree itself but would just make it easier for the bindings 
themselves.

Conor.