Re: [PATCH v2] crypto: atmel: add support for AES and SHA IPs available on lan966x SoC

[Tudor.Ambarus]

On 1/28/22 09:17, Kavyasree Kotagiri wrote:
> This patch adds support for hardware version of AES and SHA IPs
> available on lan966x SoC.
> 
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@xxxxxxxxxxxxx>

Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
Tested-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>

tested with sama7g5 which has:
[    0.891304] atmel_aes e1810000.aes: version: 0x702
[    0.896042] atmel_sha e1814000.sha: version: 0x700

> ---
> v1 -> v2:
> - Removed fallthrough line, as it is not required.
> 
>  drivers/crypto/atmel-aes.c | 1 +
>  drivers/crypto/atmel-sha.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
> index fe0558403191..f72c6b3e4ad8 100644
> --- a/drivers/crypto/atmel-aes.c
> +++ b/drivers/crypto/atmel-aes.c
> @@ -2509,6 +2509,7 @@ static void atmel_aes_get_cap(struct atmel_aes_dev *dd)
>  
>  	/* keep only major version number */
>  	switch (dd->hw_version & 0xff0) {
> +	case 0x700:
>  	case 0x500:
>  		dd->caps.has_dualbuff = 1;
>  		dd->caps.has_cfb64 = 1;
> diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
> index 1b13f601fd95..d1628112dacc 100644
> --- a/drivers/crypto/atmel-sha.c
> +++ b/drivers/crypto/atmel-sha.c
> @@ -2508,6 +2508,7 @@ static void atmel_sha_get_cap(struct atmel_sha_dev *dd)
>  
>  	/* keep only major version number */
>  	switch (dd->hw_version & 0xff0) {
> +	case 0x700:
>  	case 0x510:
>  		dd->caps.has_dma = 1;
>  		dd->caps.has_dualbuff = 1;