Re: [PATCH v5] staging: pi433: add debugfs interface

From: Dan Carpenter
Date: Fri Feb 04 2022 - 04:02:59 EST


On Fri, Feb 04, 2022 at 09:04:32PM +1300, Paulo Miguel Almeida wrote:
> This adds debugfs interface that can be used for debugging possible
> hardware/software issues.
>
> It currently exposes the following debugfs entries for each SPI device
> probed:
>
> /sys/kernel/debug/pi433/<DEVICE>/regs
> ...
>
> The 'regs' file contains all rf69 uC registers values that are useful
> for troubleshooting misconfigurations between 2 devices. It contains one
> register per line so it should be easy to use normal filtering tools to
> find the registers of interest if needed.
>
> Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@xxxxxxxxx>
> ---
> Changelog:
>
> v5: I had mistakenly forgotten to git add changes to the rf69.(c|h) in
> the previous patch

Oops.

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter