Re: [PATCH v3 12/14] arm64: dts: qcom: sc7280: Add herobrine-r1

From: Doug Anderson
Date: Thu Feb 03 2022 - 18:35:05 EST


Hi,

On Wed, Feb 2, 2022 at 1:24 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> +&pcie1_clkreq_n {
> + bias-disable;
> + drive-strength = <2>;
> +};

As per the discussion [1] then maybe the above should be
`bias-pull-up` instead of `bias-disable`. I'm happy to spin this, have
it fixed by the maintainer when applied, or do a follow-up patch to
fix this. Please let me know.

-Doug

[1] https://lore.kernel.org/r/CAD=FV=UKKZaHHz3-idahLg-ey3xmSZWKeTVVipzpZNQAkUVKmQ@xxxxxxxxxxxxxx