Re: [ASUS EC Sensors v8 0/3]

From: Guenter Roeck
Date: Thu Feb 03 2022 - 13:54:59 EST


On 2/2/22 23:09, Oleksandr Natalenko wrote:
Hello.

On čtvrtek 3. února 2022 4:48:53 CET Eugene Shalygin wrote:
Oleksandr sent an informal one already.


He wrote:

"Given minor changes against v7, I think my "Tested-by:" should have been preserved."

which doesn't mean he tested again, only that in his opinion
the tags should have been preserved.

This is not what I meant, but my wording could be better, yes.

BTW, the changes were not of that kind to drop Tested-by: tag, really.

Oleksandre, could you, please, let us know did you actually test the
v8 code and if so provide us with the Tested-by: tag?

Yes, I do run this version now, and it works fine for me.

Tested-by: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>


Ok, based on that I'll apply the series on top of hwmon-next with your
Tested-by:.

Guenter

That means that I am left with either accepting the series without any
Tested-by: and/or Reviewed-by: tags, or I have to wait for some. I guess
you are telling me that I won't get any additional tags, so I'll have to
go in myself and have a closer look. I'll try to do that in the next week
or two.

Thank you, I understand now. If Oleksandr does not reply in a few days
I will send the update with another board
(fully duplicating information for its base variant), tested by a
Libre Hardware Monitor user.

Thanks.

Best regards,
Eugene