Re: [PATCH 5.16 0873/1039] PCI: pciehp: Use down_read/write_nested(reset_lock) to fix lockdep errors

From: Greg Kroah-Hartman
Date: Thu Feb 03 2022 - 09:49:43 EST


On Wed, Feb 02, 2022 at 08:36:13PM +0100, Lukas Wunner wrote:
> On Tue, Jan 25, 2022 at 01:42:38PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 25, 2022 at 06:23:23AM -0600, Bjorn Helgaas wrote:
> > > On Mon, Jan 24, 2022 at 07:44:22PM +0100, Greg Kroah-Hartman wrote:
> > > > From: Hans de Goede <hdegoede@xxxxxxxxxx>
> > > >
> > > > commit 085a9f43433f30cbe8a1ade62d9d7827c3217f4d upstream.
> > >
> > > I would hold off on backporting the pciehp changes until we resolve
> > > this regression in v5.17-rc1:
> > >
> > > https://bugzilla.kernel.org/show_bug.cgi?id=215525
> >
> > Thanks, I will drop it from all queues now. If it gets resolved, please
> > email stable@vger and we will be glad to add it back, along with the
> > fix.
>
> This turned out not to be an actual regression. According to Bjorn,
> "it was arguably a bug that it *did* work before", see:
>
> https://lore.kernel.org/linux-pci/20220202164308.GA17822@bhelgaas/
>
> Also, the culprit was not pciehp, but rather a change to _OSC handling
> for VMD devices in commit 04b12ef163d1.
>
> Thus, please consider re-adding these upstream commits to the stable queues:
>
> 085a9f43433f30cbe8a1ade62d9d7827c3217f4d (5.16, 5.15, 5.10)

Already in the 5.10.94 5.15.17 5.16.3 releases :)

> 23584c1ed3e15a6f4bfab8dc5a88d94ab929ee12 (5.16, 5.15, 5.10, 5.4)

Now queued up, thanks.

greg k-h