Re: [PATCH v2 1/2] pinctrl: nuvoton: npcm7xx: Use %zd printk format for ARRAY_SIZE()

[Jonathan Neuschäfer]

On Thu, Feb 03, 2022 at 04:16:56PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 3, 2022 at 3:37 PM Jonathan Neuschäfer
> <j.neuschaefer@xxxxxxx> wrote:
> >
> > When compile-testing on 64-bit architectures, GCC complains about the
> > mismatch of types between the %d format specifier and value returned by
> > ARRAY_LENGTH(). Use %zd, which is correct everywhere.
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Fixes: 3b588e43ee5c7 ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver")
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> 
> ...
> 
> > -       dev_dbg(npcm->dev, "group size: %d\n", ARRAY_SIZE(npcm7xx_groups));
> > +       dev_dbg(npcm->dev, "group size: %zd\n", ARRAY_SIZE(npcm7xx_groups));
> 
> Dunno how it's slipped away, but the proper specifier is %zu.

Right, I should have noticed that.

> I guess that's what I also mentioned in reply to LKP's report.

True,

>> Should be %zu


Thanks,
Jonathan

Attachment: signature.asc
Description: PGP signature