Re: [PATCH v2 1/3] arm64: dts: qcom: sc7280: Add nodes for va tx and rx macros and external codecs

[Srinivasa Rao Mandadapu]

On 1/5/2022 3:53 AM, Vincent Knecht wrote:
Thanks for Your team Vincent!!!
> Le lundi 03 janvier 2022 à 16:42 +0530, Srinivasa Rao Mandadapu a écrit :
> > SC7280 has VA, TX and RX macros with SoundWire Controllers to attach with
> > codecs like WCD938x, max98360a using soundwire masters and i2s bus.
> > Add these nodes for sc7280 based platforms audio use case.
> > Add tlmm gpio property in wcd938x node for switching CTIA/OMTP Headset.
> >
> > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> > Co-developed-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx>
> > Signed-off-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sc7280-crd.dts  |   4 ++
> >   arch/arm64/boot/dts/qcom/sc7280-idp.dtsi |  52 ++++++++++++++
> >   arch/arm64/boot/dts/qcom/sc7280.dtsi     | 113 +++++++++++++++++++++++++++++++
> >   3 files changed, 169 insertions(+)
> [...]
>
>
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > index ddeb508..94614c9 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > @@ -636,3 +636,55 @@
> >                  bias-pull-up;
> >          };
> >   };
> > +
> > +&swr0 {
> > +       wcd_rx: wcd938x-rx{
> Space before brace...
Okay.
> > +               compatible = "sdw20217010d00";
> > +               reg = <0 4>;
> > +               #sound-dai-cells = <1>;
> > +               qcom,rx-port-mapping = <1 2 3 4 5>;
> > +       };
> > +};
> > +
> > +&swr1 {
> > +       wcd_tx: wcd938x-tx{
> Ditto...
Okay.
> > +               compatible = "sdw20217010d00";
> > +               reg = <0 3>;
> > +               #sound-dai-cells = <1>;
> > +               qcom,tx-port-mapping = <1 2 3 4>;
> > +       };
> > +};
> > +
> > +&soc {
> > +       max98360a: audio-codec-0 {
> > +               compatible = "maxim,max98360a";
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&amp_en>;
> > +               sdmode-gpios = <&tlmm 63 GPIO_ACTIVE_HIGH>;
> > +               #sound-dai-cells = <0>;
> > +       };
> > +
> > +       wcd938x: codec {
> > +               compatible = "qcom,wcd9380-codec";
> > +               #sound-dai-cells = <1>;
> > +
> > +               reset-gpios = <&tlmm 83 0>;
> GPIO_ACTIVE_HIGH ?
Okay. Will change accordingly.
>