Re: [PATCH v1 1/1] amiserial: Drop duplicate NULL check in shutdown()

[Jiri Slaby]

On 02. 02. 22, 17:56, Andy Shevchenko wrote:
> The free_page(addr), which becomes free_pages(addr, 0) checks addr
> against 0. No need to repeat this check in the caller.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Acked-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

> ---
>   drivers/tty/amiserial.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 1e60dbef676c..533d02b38e02 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -538,10 +538,8 @@ static void shutdown(struct tty_struct *tty, struct serial_state *info)
>   	 */
>   	free_irq(IRQ_AMIGA_VERTB, info);
>   
> -	if (info->xmit.buf) {
> -		free_page((unsigned long) info->xmit.buf);
> -		info->xmit.buf = NULL;
> -	}
> +	free_page((unsigned long)info->xmit.buf);
> +	info->xmit.buf = NULL;
>   
>   	info->IER = 0;
>   	amiga_custom.intena = IF_RBF | IF_TBE;


--
js
suse labs