Re: [PATCH 7/8] VMCI: dma dg: add support for DMA datagrams sends
From: kernel test robot
Date: Wed Feb 02 2022 - 19:49:50 EST
Hi Jorgen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linux/master linus/master v5.17-rc2 next-20220202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 7ab004dbcbee38b8a70798835d3ffcd97a985a5e
config: i386-randconfig-a013-20220131 (https://download.01.org/0day-ci/archive/20220203/202202030803.BfgZqtfl-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 6b1e844b69f15bb7dffaf9365cd2b355d2eb7579)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/303777a2a8daa11d529827395318bb698ddee57e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
git checkout 303777a2a8daa11d529827395318bb698ddee57e
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/misc/vmw_vmci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
drivers/misc/vmw_vmci/vmci_guest.c:103:14: warning: no previous prototype for function 'vmci_read_reg' [-Wmissing-prototypes]
unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
^
drivers/misc/vmw_vmci/vmci_guest.c:103:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
^
static
drivers/misc/vmw_vmci/vmci_guest.c:110:6: warning: no previous prototype for function 'vmci_write_reg' [-Wmissing-prototypes]
void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
^
drivers/misc/vmw_vmci/vmci_guest.c:110:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
^
static
>> drivers/misc/vmw_vmci/vmci_guest.c:118:5: warning: no previous prototype for function 'vmci_write_data' [-Wmissing-prototypes]
int vmci_write_data(struct vmci_guest_device *dev, struct vmci_datagram *dg)
^
drivers/misc/vmw_vmci/vmci_guest.c:118:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int vmci_write_data(struct vmci_guest_device *dev, struct vmci_datagram *dg)
^
static
3 warnings generated.
vim +/vmci_write_data +118 drivers/misc/vmw_vmci/vmci_guest.c
109
> 110 void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
111 {
112 if (dev->mmio_base != NULL)
113 writel(val, dev->mmio_base + reg);
114 else
115 iowrite32(val, dev->iobase + reg);
116 }
117
> 118 int vmci_write_data(struct vmci_guest_device *dev, struct vmci_datagram *dg)
119 {
120 int result;
121
122 if (dev->mmio_base != NULL) {
123 struct vmci_data_in_out_header *buffer_header = dev->tx_buffer;
124 u8 *dg_out_buffer = (u8 *)(buffer_header + 1);
125
126 if (VMCI_DG_SIZE(dg) > VMCI_MAX_DG_SIZE)
127 return VMCI_ERROR_INVALID_ARGS;
128
129 /*
130 * Initialize send buffer with outgoing datagram
131 * and set up header for inline data. Device will
132 * not access buffer asynchronously - only after
133 * the write to VMCI_DATA_OUT_LOW_ADDR.
134 */
135 memcpy(dg_out_buffer, dg, VMCI_DG_SIZE(dg));
136 buffer_header->opcode = 0;
137 buffer_header->size = VMCI_DG_SIZE(dg);
138 buffer_header->busy = 1;
139
140 vmci_write_reg(dev, lower_32_bits(dev->tx_buffer_base),
141 VMCI_DATA_OUT_LOW_ADDR);
142
143 /* Caller holds a spinlock, so cannot block. */
144 spin_until_cond(buffer_header->busy == 0);
145
146 result = vmci_read_reg(vmci_dev_g, VMCI_RESULT_LOW_ADDR);
147 if (result == VMCI_SUCCESS)
148 result = (int)buffer_header->result;
149 } else {
150 iowrite8_rep(dev->iobase + VMCI_DATA_OUT_ADDR,
151 dg, VMCI_DG_SIZE(dg));
152 result = vmci_read_reg(vmci_dev_g, VMCI_RESULT_LOW_ADDR);
153 }
154
155 return result;
156 }
157
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx