Re: [PATCH 6/8] VMCI: dma dg: allocate send and receive buffers for DMA datagrams
From: kernel test robot
Date: Wed Feb 02 2022 - 19:18:41 EST
Hi Jorgen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linux/master linus/master v5.17-rc2 next-20220202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 7ab004dbcbee38b8a70798835d3ffcd97a985a5e
config: i386-randconfig-s002 (https://download.01.org/0day-ci/archive/20220203/202202030713.SJ9T0zv6-lkp@xxxxxxxxx/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/a5ca330527cc5a2ed5eba621707076ab15d856e5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
git checkout a5ca330527cc5a2ed5eba621707076ab15d856e5
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/misc/vmw_vmci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
sparse warnings: (new ones prefixed by >>)
drivers/misc/vmw_vmci/vmci_guest.c:105:45: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got char * @@
drivers/misc/vmw_vmci/vmci_guest.c:105:45: sparse: expected void const volatile [noderef] __iomem *addr
drivers/misc/vmw_vmci/vmci_guest.c:105:45: sparse: got char *
drivers/misc/vmw_vmci/vmci_guest.c:102:14: sparse: sparse: symbol 'vmci_read_reg' was not declared. Should it be static?
drivers/misc/vmw_vmci/vmci_guest.c:112:44: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got char * @@
drivers/misc/vmw_vmci/vmci_guest.c:112:44: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/vmw_vmci/vmci_guest.c:112:44: sparse: got char *
drivers/misc/vmw_vmci/vmci_guest.c:109:6: sparse: sparse: symbol 'vmci_write_reg' was not declared. Should it be static?
drivers/misc/vmw_vmci/vmci_guest.c:514:27: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected char *mmio_base @@ got void [noderef] __iomem * @@
drivers/misc/vmw_vmci/vmci_guest.c:514:27: sparse: expected char *mmio_base
drivers/misc/vmw_vmci/vmci_guest.c:514:27: sparse: got void [noderef] __iomem *
>> drivers/misc/vmw_vmci/vmci_guest.c:869:43: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void [noderef] __iomem * @@ got char *mmio_base @@
drivers/misc/vmw_vmci/vmci_guest.c:869:43: sparse: expected void [noderef] __iomem *
drivers/misc/vmw_vmci/vmci_guest.c:869:43: sparse: got char *mmio_base
vim +869 drivers/misc/vmw_vmci/vmci_guest.c
813
814 static void vmci_guest_remove_device(struct pci_dev *pdev)
815 {
816 struct vmci_guest_device *vmci_dev = pci_get_drvdata(pdev);
817 int vmci_err;
818
819 dev_dbg(&pdev->dev, "Removing device\n");
820
821 atomic_dec(&vmci_num_guest_devices);
822
823 vmci_qp_guest_endpoints_exit();
824
825 vmci_err = vmci_event_unsubscribe(ctx_update_sub_id);
826 if (vmci_err < VMCI_SUCCESS)
827 dev_warn(&pdev->dev,
828 "Failed to unsubscribe from event (type=%d) with subscriber (ID=0x%x): %d\n",
829 VMCI_EVENT_CTX_ID_UPDATE, ctx_update_sub_id, vmci_err);
830
831 spin_lock_irq(&vmci_dev_spinlock);
832 vmci_dev_g = NULL;
833 vmci_pdev = NULL;
834 spin_unlock_irq(&vmci_dev_spinlock);
835
836 dev_dbg(&pdev->dev, "Resetting vmci device\n");
837 vmci_write_reg(vmci_dev, VMCI_CONTROL_RESET, VMCI_CONTROL_ADDR);
838
839 /*
840 * Free IRQ and then disable MSI/MSI-X as appropriate. For
841 * MSI-X, we might have multiple vectors, each with their own
842 * IRQ, which we must free too.
843 */
844 if (vmci_dev->exclusive_vectors) {
845 free_irq(pci_irq_vector(pdev, 1), vmci_dev);
846 if (vmci_dev->mmio_base != NULL)
847 free_irq(pci_irq_vector(pdev, 2), vmci_dev);
848 }
849 free_irq(pci_irq_vector(pdev, 0), vmci_dev);
850 pci_free_irq_vectors(pdev);
851
852 tasklet_kill(&vmci_dev->datagram_tasklet);
853 tasklet_kill(&vmci_dev->bm_tasklet);
854
855 if (vmci_dev->notification_bitmap) {
856 /*
857 * The device reset above cleared the bitmap state of the
858 * device, so we can safely free it here.
859 */
860
861 dma_free_coherent(&pdev->dev, PAGE_SIZE,
862 vmci_dev->notification_bitmap,
863 vmci_dev->notification_base);
864 }
865
866 vmci_free_dg_buffers(vmci_dev);
867
868 if (vmci_dev->mmio_base != NULL)
> 869 pci_iounmap(pdev, vmci_dev->mmio_base);
870
871 /* The rest are managed resources and will be freed by PCI core */
872 }
873
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx