Re: [PATCH 1/4] Compiler Attributes: Add Clang's __pass_object_size

From: Miguel Ojeda
Date: Wed Feb 02 2022 - 16:19:53 EST


On Wed, Feb 2, 2022 at 10:09 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> It's the kind of detail I feel like I might forget a month from now, so
> I added it as a bit of a hint. If you think it's too redundant, I can
> leave it off.

If you think it is valuable having it nearby (e.g. when inspecting the
definition of the attribute in a call site), then it is fine having
them -- I am all for documentation (and we could consider having a
small summary/one-liner for all attributes). But, in general, I would
avoid repeating all the compiler docs (or, if needed, we could fix
those upstream if they are not clear etc.).

Thanks!

Cheers,
Miguel