Re: [PATCH] hwtracing: coresight: Replace acpi_bus_get_device()

[Suzuki K Poulose]

Hi Rafael

On 01/02/2022 17:58, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Replace acpi_bus_get_device() that is going to be dropped with
> acpi_fetch_acpi_dev().
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>


> ---
>   drivers/hwtracing/coresight/coresight-platform.c |    8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> Index: linux-pm/drivers/hwtracing/coresight/coresight-platform.c
> ===================================================================
> --- linux-pm.orig/drivers/hwtracing/coresight/coresight-platform.c
> +++ linux-pm/drivers/hwtracing/coresight/coresight-platform.c
> @@ -626,7 +626,7 @@ static int acpi_coresight_parse_link(str
>   				     const union acpi_object *link,
>   				     struct coresight_connection *conn)
>   {
> -	int rc, dir;
> +	int dir;
>   	const union acpi_object *fields;
>   	struct acpi_device *r_adev;
>   	struct device *rdev;
> @@ -643,9 +643,9 @@ static int acpi_coresight_parse_link(str
>   	    fields[3].type != ACPI_TYPE_INTEGER)
>   		return -EINVAL;
>   
> -	rc = acpi_bus_get_device(fields[2].reference.handle, &r_adev);
> -	if (rc)
> -		return rc;
> +	r_adev = acpi_fetch_acpi_dev(fields[2].reference.handle);
> +	if (!r_adev)
> +		return -ENODEV;
>   

Is this patch part of a series ? I don't see acpi_fetch_acpi_dev()
in v5.17-rc1, which our tree is based on at the moment. Please could
you point us to the changes ?

Also do you expect to pull this via your tree ?

Cheers
Suzuki

>   	dir = fields[3].integer.value;
>   	if (dir == ACPI_CORESIGHT_LINK_MASTER) {