Re: [PATCH] memblock: Remove unused io.h include

From: Karolina Drobnik
Date: Wed Feb 02 2022 - 03:43:43 EST


Hi Mike,

Thanks for taking a look at my patch.

On Tue, 2022-02-01 at 17:26 +0200, Mike Rapoport wrote:
> As Matthew pointed out [1], many architectures put their definition
> of virt_to_phys() in asm/io.h, e.g.
>
> arch/powerpc/include/asm/io.h:#define virt_to_phys virt_to_phys
> arch/sh/include/asm/io.h:#define virt_to_phys(address)  ((unsigned
> long)(address))
> arch/x86/include/asm/io.h:#define virt_to_phys virt_to_phys
>
> which means memblock needs this header for declaration of
> virt_to_phys().
>
> Although it is included indirectly, let's keep it for now.

OK, will leave it as it is then.


Many thanks,
Karolina