Re: [PATCH v2 1/2] dt:bindings:iio:frequency: Add ADMV4420 doc

From: Rob Herring
Date: Tue Feb 01 2022 - 22:41:04 EST


On Tue, 01 Feb 2022 18:23:50 +0200, Cristian Pop wrote:
> Add device tree bindings for the ADMV4420 K band downconverter.
>
> Signed-off-by: Cristian Pop <cristian.pop@xxxxxxxxxx>
> ---
> changes in v2:
> - Fix indentation
> - Remove '|', there is no formatting to persevere
> - Add plank line before 'properties:'
> - replace '_' with '-' in property names
> .../bindings/iio/frequency/adi,admv4420.yaml | 54 +++++++++++++++++++
> 1 file changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml:13:5: [warning] wrong indentation: expected 2 but found 4 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.example.dt.yaml: admv4420@0: adi,lo-freq-hz: 'anyOf' conditional failed, one must be fixed:
16743700000 is greater than the maximum of 4294967295
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/property-units.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1587310

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.