Re: [PATCHv2 19/29] x86/topology: Disable CPU online/offline control for TDX guests

From: Thomas Gleixner
Date: Tue Feb 01 2022 - 19:09:42 EST


On Mon, Jan 24 2022 at 18:02, Kirill A. Shutemov wrote:
> static bool intel_cc_platform_has(enum cc_attr attr)
> {
> - if (attr == CC_ATTR_GUEST_UNROLL_STRING_IO)
> + switch (attr) {
> + case CC_ATTR_GUEST_UNROLL_STRING_IO:
> + case CC_ATTR_HOTPLUG_DISABLED:
> return true;
> + default:
> + return false;
> + }
>
> return false;

Sigh. If 'default:' returns false then this final return cannot be
reached, no?

Thanks,

tglx