Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for suspend/resume

[Kenneth R. Crudup]

On Wed, 2 Feb 2022, Vidya Sagar wrote:

> BTW, I see that the ASPM L1SS capability is supported by only two endpoints
> viz. KIOXIA's NVMe drive and Realtek's Card reader. None of the root ports
> seem to have the support. So, I'm wondering how was it even getting enabled in
> the first place earlier?

> (OR)

> was it the case that L1SS sub-states were never enabled earlier also and the
> issue was occurring without having ASPM L1SS enabled? (but with only L0s and
> L1 enabled??)

I'm not proficient enough in PCIe to be able to be sure of the answers to those-
what can/could I do to determine this?

> Also, I see that from 'before' and 'after' logs that for both NVMe and Card
> reader and their corresponding root ports, none of the ASPM states are enabled
> (not even L0s or L1).
> Did you set the policy to 'powersupersave' before hibernating the system?

Yeah:

CONFIG_PCIEASPM_POWER_SUPERSAVE=y

My laptop loses ~1.5%/hr in S3; I was trying anything I could to reduce that,
if possible.

	-Kenny

-- 
Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA