Re: [PATCH] srcu: make srcu_size_state_name static

From: Paul E. McKenney
Date: Tue Feb 01 2022 - 14:23:55 EST


On Sat, Jan 29, 2022 at 11:45:02AM +0800, Jiapeng Chong wrote:
> This symbol is not used outside of srcutree.c, so marks it static.
>
> Fixes the following sparse warning:
>
> kernel/rcu/srcutree.c:1426:12: warning: symbol 'srcu_size_state_name'
> was not declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>

And I did queue and push this, good catch, thank you!

Thanx, Paul

> ---
> kernel/rcu/srcutree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index 4201815744d8..31dbd41332f6 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -1423,7 +1423,7 @@ void srcutorture_get_gp_data(enum rcutorture_type test_type,
> }
> EXPORT_SYMBOL_GPL(srcutorture_get_gp_data);
>
> -const char * const srcu_size_state_name[] =
> +static const char * const srcu_size_state_name[] =
> {
> "SRCU_SIZE_SMALL",
> "SRCU_SIZE_ALLOC",
> --
> 2.20.1.7.g153144c
>