Re: [PATCH 3/5] coredump: Remove the WARN_ON in dump_vma_snapshot

From: Jann Horn
Date: Tue Feb 01 2022 - 13:35:43 EST


On Mon, Jan 31, 2022 at 7:46 PM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
> The condition is impossible and to the best of my knowledge has never
> triggered.
>
> We are in deep trouble if that conditions happens and we walk past
> the end of our allocated array.
>
> So delete the WARN_ON and the code that makes it look like the kernel
> can handle the case of walking past the end of it's vma_meta array.
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Reviewed-by: Jann Horn <jannh@xxxxxxxxxx>