Re: [PATCH 02/17] ARM: dts: qcom: add gsbi6 missing definition for ipq8064

From: Jonathan McDowell
Date: Tue Feb 01 2022 - 09:38:06 EST


On Tue, Jan 18, 2022 at 02:20:32AM +0100, Ansuel Smith wrote:
> Add gsbi6 missing definition for ipq8064.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> ---
> arch/arm/boot/dts/qcom-ipq8064.dtsi | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index cc6ca9013ab1..094125605bea 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -665,6 +665,33 @@ spi@1a280000 {
> };
> };
>
> + gsbi6: gsbi@16500000 {
> + status = "disabled";
> + compatible = "qcom,gsbi-v1.0.0";
> + cell-index = <6>;
> + reg = <0x16500000 0x100>;
> + clocks = <&gcc GSBI6_H_CLK>;
> + clock-names = "iface";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + syscon-tcsr = <&tcsr>;
> +
> + gsbi6_i2c: i2c@16580000 {
> + compatible = "qcom,i2c-qup-v1.1.1";
> + reg = <0x16580000 0x1000>;
> + interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>;
> +
> + clocks = <&gcc GSBI6_QUP_CLK>, <&gcc GSBI6_H_CLK>;
> + clock-names = "core", "iface";
> + status = "disabled";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };

Can you include the SPI definition too? The RB3011 has its SPI LCD
living here.

gsbi6_spi: spi@16580000 {
compatible = "qcom,spi-qup-v1.1.1";
reg = <0x16580000 0x1000>;
interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>;

clocks = <&gcc GSBI6_QUP_CLK>, <&gcc GSBI6_H_CLK>;
clock-names = "core", "iface";
status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};

> + };
> +
> gsbi7: gsbi@16600000 {
> status = "disabled";
> compatible = "qcom,gsbi-v1.0.0";
> --
> 2.33.1
>

J.

--
] https://www.earth.li/~noodles/ [] "send me the rhubarb" -- Martin [
] PGP/GPG Key @ the.earth.li [] Brooks on the risks of dog poo in [
] via keyserver, web or email. [] compost [
] RSA: 4096/0x94FA372B2DA8B985 [] [