Re: [PATCH v1] drivers/base/memory: add memory block to memory group after registration succeeded

From: Michal Hocko
Date: Tue Feb 01 2022 - 07:10:55 EST


On Mon 31-01-22 17:01:23, Andrew Morton wrote:
> On Fri, 28 Jan 2022 15:45:40 +0100 David Hildenbrand <david@xxxxxxxxxx> wrote:
>
> > If register_memory() fails, we freed the memory block but already added
> > the memory block to the group list, not good. Let's defer adding the
> > block to the memory group to after registering the memory block device.
> >
> > We do handle it properly during unregister_memory(), but that's not
> > called when the registration fails.
> >
>
> I guess this has never been known to happen. So I queued the fix for
> 5.18-rc1, cc:stable.

I do not think this is worth stable backporting. Chances of a failure
are pretty small and I am not aware of any existing report.

--
Michal Hocko
SUSE Labs