Re: [PATCH 6/6] memcg: do not tweak node in alloc_mem_cgroup_per_node_info

From: Michal Hocko
Date: Tue Feb 01 2022 - 04:51:43 EST


On Tue 01-02-22 02:45:44, Wei Yang wrote:
> On Thu, Jan 27, 2022 at 09:53:05AM +0100, Michal Hocko wrote:
> >From: Wei Yang <richard.weiyang@xxxxxxxxx>
> >
> >alloc_mem_cgroup_per_node_info is allocated for each possible node and
> >this used to be a problem because not !node_online nodes didn't have
> ^^^ a typo here?
>
> !node_online nodes is enough?

Yes. Fixed up. Thx!


> >appropriate data structure allocated. This has changed by "mm: handle
> >uninitialized numa nodes gracefully" so we can drop the special casing
> >here.
> >
> >Signed-off-by: Wei Yang <richard.weiyang@xxxxxxxxx>
> >Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
>
> --
> Wei Yang
> Help you, Help me

--
Michal Hocko
SUSE Labs