Re: [PATCH v7 3/3] mmc: Add driver for LiteX's LiteSDCard interface

[Andy Shevchenko]

On Fri, Jan 7, 2022 at 7:06 PM Gabriel Somlo <gsomlo@xxxxxxxxx> wrote:
>
> LiteX (https://github.com/enjoy-digital/litex) is a SoC framework
> that targets FPGAs. LiteSDCard is a small footprint, configurable
> SDCard core commonly used in LiteX designs.
>
> The driver was first written in May 2020 and has been maintained
> cooperatively by the LiteX community. Thanks to all contributors!

...

> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * LiteX LiteSDCard driver
> + *
> + * Copyright (C) 2019-2020 Antmicro <contact@xxxxxxxxxxxx>
> + * Copyright (C) 2019-2020 Kamil Rakoczy <krakoczy@xxxxxxxxxxxx>
> + * Copyright (C) 2019-2020 Maciej Dudek <mdudek@xxxxxxxxxxxxxxxxxxxxxxxx>
> + * Copyright (C) 2020 Paul Mackerras <paulus@xxxxxxxxxx>
> + * Copyright (C) 2020-2021 Gabriel Somlo <gsomlo@xxxxxxxxx>

> + *

I guess I have commented on this and there was no discussion about the
necessity of this blank line. I dunno what else has been ignored, so I
will wait either for the continuation of the discussion (as per v6) or
amending code in v8.

> + */

...

On top of that it might still be the ordering issues in the error path
of ->probe() and in ->remove(). I believe we will likely see v8.

-- 
With Best Regards,
Andy Shevchenko