Re: [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes

[Suman Anna]

Hi Rob,

On 1/6/22 9:04 PM, Rob Herring wrote:
> Based on the example, the TI K3 DSP and R5 have 2 mailboxes, but the schema
> says 1. Fix the schema.

No, 1 is correct. The OMAP Mailbox binding uses #mbox-cells as 1 and not 0, and
uses a phandle as the cell-value.

regards
Suman

> 
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml         | 2 +-
>  .../devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml         | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index 5ec6505ac408..648144fa1582 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -53,7 +53,7 @@ properties:
>        OMAP Mailbox specifier denoting the sub-mailbox, to be used for
>        communication with the remote processor. This property should match
>        with the sub-mailbox node used in the firmware image.
> -    maxItems: 1
> +    maxItems: 2
>  
>    memory-region:
>      minItems: 2
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> index eeef255c4045..2c5f91ea5296 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> @@ -135,7 +135,7 @@ patternProperties:
>            OMAP Mailbox specifier denoting the sub-mailbox, to be used for
>            communication with the remote processor. This property should match
>            with the sub-mailbox node used in the firmware image.
> -        maxItems: 1
> +        maxItems: 2
>  
>        memory-region:
>          description: |
>