Re: [PATCH] fs/pipe: local vars has to match types of proper pipe_inode_info fields

From: Christian Brauner
Date: Fri Jan 07 2022 - 07:06:27 EST


On Thu, Jan 06, 2022 at 09:19:46AM -0800, Andrei Vagin wrote:
> head, tail, ring_size are declared as unsigned int, so all local
> variables that operate with these fields have to be unsigned to avoid
> signed integer overflow.
>
> Right now, it isn't an issue because the maximum pipe size is limited by
> 1U<<31.
>
> Cc: Dmitry Safonov <0x7f454c46@xxxxxxxxx>
> Suggested-by: Dmitry Safonov <0x7f454c46@xxxxxxxxx>
> Signed-off-by: Andrei Vagin <avagin@xxxxxxxxx>
> ---

Looks good,
Acked-by: Christian Brauner <christian.brauner@xxxxxxxxxx>