Re: [PATCH] tcp: tcp_send_challenge_ack delete useless param `skb`

From: Jakub Kicinski
Date: Thu Jan 06 2022 - 21:35:57 EST


On Thu, 6 Jan 2022 08:32:45 +0800 Benjamin.Yim yan2228598786@xxxxxxxxx
wrote:
> From: Benjamin <yan2228598786@xxxxxxxxx>
>
> After this parameter is passed in, there is no usage, and deleting it will
> not bring any impact.
>
> Signed-off-by: Benjamin <yan2228598786@xxxxxxxxx>

This one did not make it to patchwork or lore.

Please resend. Perhaps the reason was the odd looking From header:

From: Benjamin.Yim yan2228598786@xxxxxxxxx

Maybe it should have <> brackets? Please also use your full name for
the patch author and sign-off - should you be "Benjamin Yim"?