Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning

From: Miles Chen
Date: Thu Jan 06 2022 - 20:40:53 EST


Hi Matthias,

>> I'm still not happy with the commit subject, I think it is misleading. Clang
>> only helped to find the bug, but the we are fixing something else, that's not
>> just a clang warning. But I don't want to nit-pick too much so:
>>
>> Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>

> thanks. I think you are right.
> I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the
> clang part and submit patch v4.

I posted patch v4 https://lore.kernel.org/linux-mediatek/20220103054706.8072-1-miles.chen@xxxxxxxxxxxx/
without your reviewed-by tag.

Would you mind taking a look at the patch?

Miles