Re: [PATCH bpf-next v4 2/3] bpf: Add selftests

From: Alexei Starovoitov
Date: Thu Jan 06 2022 - 19:57:00 EST


On Tue, Jan 4, 2022 at 7:03 PM Joe Burton <jevburton.kernel@xxxxxxxxx> wrote:
> +
> +enum BoolOrErr {
> + TRUE = 0,
> + FALSE = 1,
> + ERROR = 2,
> +};

No camel style in the kernel please.

> +++ b/tools/testing/selftests/bpf/progs/bpf_map_trace_common.h
> @@ -0,0 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2022 Google */
> +#pragma once

Didn't you say that pragma once was removed?

> +
> +enum MapAccessLocations {

here and other places.