Re: [PATCH v2 4/5] selftests/resctrl: Change default limited time to 120 seconds for resctrl_tests

[Reinette Chatre]

Hi Shaopeng Tan,

On 12/13/2021 2:01 AM, Shaopeng Tan wrote:
> This commit changed the default limited time(45s) to 120 seconds for

(This commit)

> resctrl_tests by adding "setting" file.  Since 45 seconds may not be
> enough on some machine environments.

This sounds very imprecise when you say "may not be enough". From what I
understand you have already encountered systems where this is not enough
so you have established that 45 seconds is too short. The next question is,
how was 120 seconds determined and how do you know it will be enough?

> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxxxxx>
> ---
>  tools/testing/selftests/resctrl/settings | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 tools/testing/selftests/resctrl/settings
> 
> diff --git a/tools/testing/selftests/resctrl/settings b/tools/testing/selftests/resctrl/settings
> new file mode 100644
> index 000000000000..6091b45d226b
> --- /dev/null
> +++ b/tools/testing/selftests/resctrl/settings
> @@ -0,0 +1 @@
> +timeout=120

Reinette