Re: [PATCH] tty/serial: Check for null pointer after calling devm_ioremap

From: Greg KH
Date: Thu Jan 06 2022 - 10:01:26 EST


On Thu, Jan 06, 2022 at 05:06:31PM +0800, Jiasheng Jiang wrote:
> As the possible failure of the allocation, the devm_ioremap() may return
> NULL pointer.

I do not understand this sentence.

> And the 'port->membase' will be directly used in mlb_usio_startup().

This does not make sense either.


> Therefore, in order to avoid the dereference of the NULL pointer, it
> should be better to add the sanity check.

What do you mean by "sanity check"?

confused,

greg k-h