Re: [PATCH] qemu_fw_cfg: use default_groups in kobj_type

From: Greg Kroah-Hartman
Date: Thu Jan 06 2022 - 08:25:38 EST


On Wed, Jan 05, 2022 at 05:56:26PM -0500, Michael S. Tsirkin wrote:
> On Wed, Jan 05, 2022 at 07:31:33PM +0100, Greg Kroah-Hartman wrote:
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field. Move the firmware qemu_fw_cfg sysfs code to use default_groups
> > field which has been the preferred way since aa30f47cf666 ("kobject: Add
> > support for default attribute groups to kobj_type") so that we can soon
> > get rid of the obsolete default_attrs field.
> >
> > Cc: Gabriel Somlo <somlo@xxxxxxx>
> > Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
> > Cc: qemu-devel@xxxxxxxxxx
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> OK then you know best I guess
>
> Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
>
> feel free to queue.

Thanks, will do!

greg k-h