Re: [PATCH v2 04/35] brcmfmac: firmware: Support having multiple alt paths

From: Hector Martin
Date: Thu Jan 06 2022 - 06:12:22 EST


On 2022/01/06 19:43, Arend van Spriel wrote:
>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h
>> index e290dec9c53d..7f4e6e359c82 100644
>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h
>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h
>> @@ -11,6 +11,8 @@
>>
>> #define BRCMF_FW_DEFAULT_PATH "brcm/"
>>
>> +#define BRCMF_FW_MAX_ALT_PATHS 8
>> +
>
> Any motivation to have 8 here today? In patch #9 I see a list of 6 paths
> in the commit message so you need 6 and rounded up here to power of 2?
>

Heh, yeah, that's just my powers-of-two-are-nice-numbers habit. I can
drop it down to 6 if you prefer.

--
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub