Re: [PATCH v5 01/14] iommu: Add dma ownership management interfaces

[Lu Baolu]

On 1/5/22 12:41 AM, Bjorn Helgaas wrote:
> > >   struct group_device {
> > > @@ -289,7 +291,12 @@ int iommu_probe_device(struct device *dev)
> > >   	mutex_lock(&group->mutex);
> > >   	iommu_alloc_default_domain(group, dev);
> > >   
> > > -	if (group->default_domain) {
> > > +	/*
> > > +	 * If device joined an existing group which has been claimed
> > > +	 * for none kernel DMA purpose, avoid attaching the default
> > > +	 * domain.
> AOL: another "none kernel DMA purpose" that doesn't read well.  Is
> this supposed to be "non-kernel"?  What does "claimed for non-kernel
> DMA purpose" mean?  What interface does that?

It's hard to read. I will rephrase it like this:

/*
 * If device joined an existing group which has been claimed, don't
 * attach the default domain.
 */

Best regards,
baolu