Re: [Resource Leak] Missing closing files in tools/bpf/bpf_asm.c

From: Andrii Nakryiko
Date: Wed Jan 05 2022 - 18:51:06 EST


On Wed, Dec 29, 2021 at 7:40 PM Ryan Cai <ycaibb@xxxxxxxxx> wrote:
>
> Dear Kernel maintainers,
> 1. In tools/bpf/bpf_asm.c, the file opened at Line 40 may not closed within the function?
> Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/tools/bpf/bpf_asm.c#L40-L49
>
> Should it be a bug? I can send patches for these.

file will be closed by the kernel on exit, but it would be better to
close it explicitly, so please feel free to send a fix

>
> Best,
> Ryan
>
>