Re: [PATCH] Revert "net: usb: r8152: Add MAC passthrough support for more Lenovo Docks"

From: Andrew Lunn
Date: Wed Jan 05 2022 - 12:36:28 EST


On Thu, Jan 06, 2022 at 12:05:28AM +0800, Aaron Ma wrote:
>
> On 1/6/22 00:01, Oliver Neukum wrote:
> >
> > On 05.01.22 16:51, Aaron Ma wrote:
> > > This reverts commit f77b83b5bbab53d2be339184838b19ed2c62c0a5.
> > >
> > > This change breaks multiple usb to ethernet dongles attached on Lenovo
> > > USB hub.
> >
> > Hi,
> >
> > now we should maybe discuss a sensible way to identify device
> > that should use passthrough. Are your reasons to not have a list
> > of devices maintainability or is it impossible?
> >
>
> The USB to ethernet ID is 0bda:8153. It's is original Realtek 8153 ID.
> It's impossible.
>
> And ocp data are 0.
> No way to identify it's from dock.

Can you at least identify the dock?

Can you have a udev rule which matches on 0bda:8153, it then walks up
the tree and checks if it is part of the dock? And it is on the
expected port of the hub within the dock, and not a USB stick plugged
into the dock on some other port of the hub?

Andrew