Re: [PATCH] ALSA: hda/realtek: Add quirk for Legion Y9000X 2020

[Baole Fang]

Sorry, this is my first time to submit patch to Linux, so I'm not quite 
familiar with the convention. Since I was changing based on v5.15.12 and 
I saw others mentioning their upstream commit, I included the that 
commit id.

Please forgive me and tell me what is supposed to be done if possible. I 
still have a lot to learn.

Best Regards,

Baole Fang

On 2022/1/5 下午6:55, Greg Kroah-Hartman wrote:
> On Wed, Jan 05, 2022 at 09:26:16AM +0100, Takashi Iwai wrote:
> > On Wed, 05 Jan 2022 04:41:01 +0100,
> > Baole Fang wrote:
> > > commit 25960cafa06e6fcd830e6c792e6a7de68c1e25ed upstream.
> > I couldn't find this commit.  Is this a bogus information?
> >
> > > Legion Y9000X 2020 has a speaker, but the speaker doesn't work.
> > > This can be fixed by applying alc285_fixup_ideapad_s740_coef
> > >   to fix the speaker's coefficients.
> > > Besides, to support the transition between the speaker and the headphone,
> > > alc287_fixup_legion_15imhg05_speakers needs to be run.
> > >
> > > Signed-off-by: Baole Fang <fbl718@xxxxxxx>
> > The code change itself looks fine, so I'd apply it if the line above
> > can be omitted.
> That commit id comes from 5.15.12, and it is the commit id of the
> release commit:
> 	25960cafa06e ("Linux 5.15.12")
> which makes no sense at all.
>
> Baole, why did you add this line?
>
> confused,
>
> greg k-h