Re: [PATCH 5/8] PM: runtime: Add EXPORT[_GPL]_RUNTIME_DEV_PM_OPS macros

[Jonathan Cameron]

On Tue, 4 Jan 2022 21:42:11 +0000
Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote:

> Similar to EXPORT[_GPL]_SIMPLE_DEV_PM_OPS, but for users with runtime-PM
> suspend/resume callbacks.
> 
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
Follow up earlier comment.  I think you want pm_ptr() around all the
entries for RUNTIME_PM_OPS

Jonathan

> ---
>  include/linux/pm_runtime.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h
> index 4af454d29281..a7f862a26c03 100644
> --- a/include/linux/pm_runtime.h
> +++ b/include/linux/pm_runtime.h
> @@ -36,6 +36,13 @@
>  			   pm_runtime_force_resume, suspend_fn, \
>  			   resume_fn, idle_fn)
>  
> +#define EXPORT_RUNTIME_DEV_PM_OPS(name, suspend_fn, resume_fn, idle_fn) \
> +	_EXPORT_DEV_PM_OPS(name, pm_runtime_force_suspend, pm_runtime_force_resume, \
> +			   suspend_fn, resume_fn, idle_fn, "")
> +#define EXPORT_GPL_RUNTIME_DEV_PM_OPS(name, suspend_fn, resume_fn, idle_fn) \
> +	_EXPORT_DEV_PM_OPS(name, pm_runtime_force_suspend, pm_runtime_force_resume, \
> +			   suspend_fn, resume_fn, idle_fn, "_gpl")
> +
>  #ifdef CONFIG_PM
>  extern struct workqueue_struct *pm_wq;
>