Re: [PATCH 1/4] media: davinci: vpif: fix unbalanced runtime PM get

From: Lad, Prabhakar
Date: Tue Jan 04 2022 - 13:05:57 EST


Hi Johan,

Thank you for the patch.

On Wed, Dec 22, 2021 at 2:20 PM Johan Hovold <johan@xxxxxxxxxx> wrote:
>
> Make sure to balance the runtime PM usage counter on driver unbind.
>
> Fixes: 407ccc65bfd2 ("[media] davinci: vpif: add pm_runtime support")
> Cc: stable@xxxxxxxxxxxxxxx # 3.9
> Cc: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> ---
> drivers/media/platform/davinci/vpif.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@xxxxxxxxx>

> diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
> index 5a89d885d0e3..9752a5ec36f7 100644
> --- a/drivers/media/platform/davinci/vpif.c
> +++ b/drivers/media/platform/davinci/vpif.c
> @@ -495,6 +495,7 @@ static int vpif_probe(struct platform_device *pdev)
>
> static int vpif_remove(struct platform_device *pdev)
> {
> + pm_runtime_put(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> return 0;
> }
> --
> 2.32.0
>

Cheers,
Prabhakar