Re: [PATCH] dmaengine: ioatdma: use default_groups in kobj_type

[Dave Jiang]

On 1/4/2022 9:33 AM, Greg Kroah-Hartman wrote:
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field.  Move the ioatdma sysfs code to use default_groups field which has
> been the preferred way since aa30f47cf666 ("kobject: Add support for
> default attribute groups to kobj_type") so that we can soon get rid of
> the obsolete default_attrs field.
>
> Cc: Vinod Koul <vkoul@xxxxxxxxxx>
> Cc: dmaengine@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Acked-by: Dave Jiang <dave.jiang@xxxxxxxxx>


> ---
>   drivers/dma/ioat/sysfs.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ioat/sysfs.c b/drivers/dma/ioat/sysfs.c
> index aa44bcd6a356..168adf28c5b1 100644
> --- a/drivers/dma/ioat/sysfs.c
> +++ b/drivers/dma/ioat/sysfs.c
> @@ -158,8 +158,9 @@ static struct attribute *ioat_attrs[] = {
>   	&intr_coalesce_attr.attr,
>   	NULL,
>   };
> +ATTRIBUTE_GROUPS(ioat);
>   
>   struct kobj_type ioat_ktype = {
>   	.sysfs_ops = &ioat_sysfs_ops,
> -	.default_attrs = ioat_attrs,
> +	.default_groups = ioat_groups,
>   };