Re: [PATCH 3/3] dt-bindings: mfd: maxim,max77802: Convert to dtschema

From: Rob Herring
Date: Tue Jan 04 2022 - 10:35:36 EST


On Tue, Dec 28, 2021 at 05:43:05PM +0100, Krzysztof Kozlowski wrote:
> Convert the MFD part of Maxim MAX77802 PMIC to DT schema format. The
> example DTS was copied from existing DTS (exynos5800-peach-pi.dts), so
> keep the license as GPL-2.0-only.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/mfd/max77802.txt | 25 ---
> .../bindings/mfd/maxim,max77802.yaml | 194 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 195 insertions(+), 26 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77802.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/max77802.txt b/Documentation/devicetree/bindings/mfd/max77802.txt
> deleted file mode 100644
> index 09decac20d91..000000000000
> --- a/Documentation/devicetree/bindings/mfd/max77802.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -Maxim MAX77802 multi-function device
> -
> -The Maxim MAX77802 is a Power Management IC (PMIC) that contains 10 high
> -efficiency Buck regulators, 32 Low-DropOut (LDO) regulators used to power
> -up application processors and peripherals, a 2-channel 32kHz clock outputs,
> -a Real-Time-Clock (RTC) and a I2C interface to program the individual
> -regulators, clocks outputs and the RTC.
> -
> -Bindings for the built-in 32k clock generator block and
> -regulators are defined in ../clk/maxim,max77802.txt and
> -../regulator/max77802.txt respectively.
> -
> -Required properties:
> -- compatible : Must be "maxim,max77802"
> -- reg : Specifies the I2C slave address of PMIC block.
> -- interrupts : I2C device IRQ line connected to the main SoC.
> -
> -Example:
> -
> - max77802: pmic@9 {
> - compatible = "maxim,max77802";
> - interrupt-parent = <&intc>;
> - interrupts = <26 IRQ_TYPE_NONE>;
> - reg = <0x09>;
> - };
> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77802.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77802.yaml
> new file mode 100644
> index 000000000000..26f49fbace18
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77802.yaml
> @@ -0,0 +1,194 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/maxim,max77802.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX77802 Power Management IC
> +
> +maintainers:
> + - Javier Martinez Canillas <javier@xxxxxxxxxxxx>
> + - Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> +
> +description: |
> + This is a part of device tree bindings for Maxim MAX77802 Power Management
> + Integrated Circuit (PMIC).
> +
> + The Maxim MAX77802 is a Power Management IC which includes voltage and
> + current regulators (10 high efficiency Buck regulators and 32 Low-DropOut
> + (LDO)), RTC and clock outputs.
> +
> + The MAX77802 provides two 32.768khz clock outputs that can be controlled
> + (gated/ungated) over I2C. The clock IDs are defined as preprocessor macros
> + in dt-bindings/clock/maxim,max77802.h.
> +
> +properties:
> + compatible:
> + const: maxim,max77802
> +
> + '#clock-cells':
> + const: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + reg:
> + maxItems: 1
> +
> + regulators:
> + $ref: ../regulator/maxim,max77802.yaml

Use absolute path: /schemas/regulator/...

With that,

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>