Re: [PATCH 1/2] EDAC: use proper list of struct attribute for attributes

From: Greg Kroah-Hartman
Date: Tue Jan 04 2022 - 05:52:05 EST


On Tue, Jan 04, 2022 at 11:38:21AM +0100, Greg Kroah-Hartman wrote:
> The edac sysfs code is doing some crazy casting of the list of
> attributes that is not necessary at all. Instead, properly point to the
> correct attribute structure in the lists, which removes the need to cast
> anything and the code is now properly typesafe (as much as sysfs
> attribute logic is typesafe...)
>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Cc: Tony Luck <tony.luck@xxxxxxxxx>
> Cc: James Morse <james.morse@xxxxxxx>
> Cc: Robert Richter <rric@xxxxxxxxxx>
> Cc: linux-edac@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/edac/edac_device_sysfs.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)

Ick, I forgot the other users like edac_pci_sysfs.c that also has this
issue, so let me go fix up this series to include that at the same time.
Sorry for the noise here...

thanks,

greg k-h