Re: [PATCH v2] RDMA/rxe: Get rid of redundant plus

[lizhijian@xxxxxxxxxxx]

On 04/01/2022 15:54, Christoph Hellwig wrote:
> On Tue, Jan 04, 2022 at 09:24:06AM +0800, Li Zhijian wrote:
>> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
>> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
>> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>>   			[RXE_ATMETH]	= RXE_BTH_BYTES
>>   						+ RXE_RDETH_BYTES
>>   						+ RXE_DETH_BYTES,
>> -			[RXE_PAYLOAD]	= RXE_BTH_BYTES +
>> +			[RXE_PAYLOAD]	= RXE_BTH_BYTES
>>   						+ RXE_ATMETH_BYTES
>> -						+ RXE_DETH_BYTES +
>> +						+ RXE_DETH_BYTES
>>   						+ RXE_RDETH_BYTES,
>>   		}
>>   	},
>> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>>   			[RXE_ATMETH]	= RXE_BTH_BYTES
>>   						+ RXE_RDETH_BYTES
>>   						+ RXE_DETH_BYTES,
>> -			[RXE_PAYLOAD]	= RXE_BTH_BYTES +
>> +			[RXE_PAYLOAD]	= RXE_BTH_BYTES
>>   						+ RXE_ATMETH_BYTES
>> -						+ RXE_DETH_BYTES +
>> +						+ RXE_DETH_BYTES
>>   						+ RXE_RDETH_BYTES,
>>   		}
>>   	},
> Please fix this up to always have the + on the continuing line which
> is the normal kernel style.
I'm so glad to hear that, i will also update the existing unconventional style in this file.