Re: [PATCH] xfs: sysfs: use default_groups in kobj_type

From: Greg Kroah-Hartman
Date: Tue Jan 04 2022 - 02:01:56 EST


On Mon, Jan 03, 2022 at 11:13:21AM -0800, Darrick J. Wong wrote:
> On Tue, Dec 28, 2021 at 03:46:41PM +0100, Greg Kroah-Hartman wrote:
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field. Move the xfs sysfs code to use default_groups field which has
> > been the preferred way since aa30f47cf666 ("kobject: Add support for
> > default attribute groups to kobj_type") so that we can soon get rid of
> > the obsolete default_attrs field.
> >
> > Cc: "Darrick J. Wong" <djwong@xxxxxxxxxx>
> > Cc: linux-xfs@xxxxxxxxxxxxxxx
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> Looks good to me. Shall I take this through the xfs tree?
>
> Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>

Please feel free to. Or if you do not want to, I can take it through my
trees, which ever is easier for you, just let me know.

thanks,

greg k-h