Re: [PATCH] scripts: kernel-doc: transform documentation into POD

From: Tomasz Warniełło
Date: Mon Jan 03 2022 - 18:56:21 EST


On Mon, 03 Jan 2022 14:57:48 -0700
Jonathan Corbet <corbet@xxxxxxx> wrote:

> One thread per version is good; please do not post new versions to old
> threads. A tool like "git send-email" can be your friend here. See
> Documentation/process/submitting-patches.rst for lots of details on how
> to submit patches.

Ok, thanks. I'll try to do it correctly this time...

> Along these lines, I appreciate that you broke up the series as I
> requested, but you overdid it a bit. Think in terms of logical changes
> and making things easy to review, and you should be able to coalesce
> things a bit.

I'm not good at guessing what seems logical to others, especially those I
don't know much. No sarcasm here. Luckily it's not that many of them, so
hopefully they'll pass the exam overdone as they are.

> >> - Stick with current coding conventions
> >
> > To be honest, I need to think this over.
>
> Think hard; if you're unable to work with the kernel project's
> conventions, there's not a lot of point in resubmitting the patches.

Let's finish this one together.

As for the actual code corrections, I see I put 1 tab too many in
two places in the last version. So I guess I just need to reduce them
by 1? No sarcasm again... So let me know before I've sent the next version,
if you please.

Ch, TW