Re: [PATCH] scripts: kernel-doc: transform documentation into POD

From: Tomasz Warniełło
Date: Mon Jan 03 2022 - 16:48:14 EST


On Mon, 03 Jan 2022 13:04:09 -0700
Jonathan Corbet <corbet@xxxxxxx> wrote:

> Tomasz Warniełło <tomasz.warniello@xxxxxxxxx> writes:
>
> > On Mon, 03 Jan 2022 11:04:53 +0200
> > Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote:
> >> In kernel, tabs are 8 characters.
> >>
> >> See Documentation/process/coding-style.rst
> >>
> >
> > I am a heretic then.
> >
> > Except for the initial dogma, I understand and agree with the rationale
> > in coding-style.rst.
> >
> > Only what if I have stared at the screen not for 20 hours, but for
> > 40 hours? Now I want to have indentation even deeper, of 16 spaces.
> > And how do I get this having 8 spaces here and there instead of tabs?
> > The system begins to fall apart.
> >
> > The misleading statement is that tabs are 8 characters long. No. They
> > are exactly 1 character long. And that's ASCII 9.
>
> This is not particularly helpful.

Not helpful? In what matter? It is a matter of fact opinion on
coding-style.rst, which Jani Nikula referred to, so I think it is both
in topic and may be helpful to some. While troublesome to some others,
that's true.

> I would like to get your work in, but need some cooperation to get
> there.
>
> Please:
>
> - Post your patch series as a single thread with a coherent cover
> letter.

Sorry, I'm a newbie in this business. I need to figure out how emails
work. Is this just one thread per version or one thread per all versions?
Can you please direct me to some documentation about this?

> - Stick with current coding conventions

To be honest, I need to think this over.

> - Avoid snide comments to reviewers.

My reply is no more snide than coding-style.rst. Compare them. It strictly
relates to it. I don't point my answer at the reviewer in any way, if that's
what you mean.

Ch, TW