Re: [PATCH 5.4 14/37] net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy_register

[Florian Fainelli]

On 1/3/2022 6:23 AM, Greg Kroah-Hartman wrote:
> From: Miaoqian Lin <linmq006@xxxxxxxxx>
>
> [ Upstream commit b45396afa4177f2b1ddfeff7185da733fade1dc3 ]
>
> The fixed_phy_get_gpiod function() returns NULL, it doesn't return error
> pointers, using NULL checking to fix this.i
>
> Fixes: 5468e82f7034 ("net: phy: fixed-phy: Drop GPIO from fixed_phy_add()")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> Link: https://lore.kernel.org/r/20211224021500.10362-1-linmq006@xxxxxxxxx
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

This patch prevents systems using fixed PHY devices from successfully 
registering, especially when those systems have a fixed PHY that does 
not use a GPIO:

[    5.971952] brcm-systemport 9300000.ethernet: failed to register 
fixed PHY
[    5.978854] brcm-systemport: probe of 9300000.ethernet failed with 
error -22
[    5.986047] brcm-systemport 9400000.ethernet: failed to register 
fixed PHY
[    5.992947] brcm-systemport: probe of 9400000.ethernet failed with 
error -22

Please drop it for now until it can be investigated. Thanks!
--
Florian