Re: [PATCH V3 1/6] tty: serial: meson: Drop the legacy compatible strings and clock code

From: Neil Armstrong
Date: Mon Jan 03 2022 - 11:35:07 EST


On 03/01/2022 17:29, Greg Kroah-Hartman wrote:
> On Mon, Jan 03, 2022 at 04:29:56PM +0100, Neil Armstrong wrote:
>>>> Would it be possible we also receive the notification when those patches are applied ?
>>>> Maybe a MAINTAINERS entry is missing so we can receive them ?
>>>
>>> That would be good, so that people can review the patches. Otherwise I
>>> have to just guess :)
>>
>> exact, I naively thought it would be matched in the:
>> N: meson
>> entry but it seems an proper entry for drivers/tty/serial/meson_uart.c is needed.
>
> Try it, does that work when running get_maintainer.pl on this patch?

Yes it does work, so no problem here

>
>>>> It would help me track those TTY and USB patches more easily.
>>>
>>> I recommend MAINTAINERS entries for drivers that are not listed and that
>>> you care about seeing the changes for.
>>
>> This is why we have a regex to match these.
>
> Great, the submitter should have used that.
>
>> I can submit a patch to have a proper entry if the regex is not enough/appropriate.
>
> Whatever makes the tools work is fine with me.
>
>> BTW can you point us how are selected the recipients of the notification messages you send ?
>
> For when I apply a patch, everyone on the ack/signed-off-by/reviewed-by
> list gets a response. I do not hit mailing lists with the notification
> as that's just too much noise.
>
> Been doing it this way for well over a decade now, nothing new here :)

Ok right, no problem, other maintainers (e.g: net, sound) and default b4 behavior is to
send notification to same recipient as original patch.

It it fits everyone for a decade, no need to change ! We have very low patches for tty & usb anyway

Neil

>
> thanks,
>
> greg k-h
>