Re: [RFC PATCH 00/34] brcmfmac: Support Apple T2 and M1 platforms

From: Hector Martin
Date: Mon Jan 03 2022 - 01:32:19 EST


On 2022/01/02 15:25, Linus Walleij wrote:
> On Sun, Dec 26, 2021 at 4:36 PM Hector Martin <marcan@xxxxxxxxx> wrote:
>
>> Merry Christmas! This year Santa brings us a 34-patch series to add
>> proper support for the Broadcom FullMAC chips used on Apple T2 and M1
>> platforms:
>
> I tried to review as best I could, when I think I know what I'm doing I state
> Reviewed-by and when I think it just LooksGoodToMe(TM) I replied
> Acked-by. If I missed some patch you can assume Acked-by from me
> on these as well.
>
> Thanks for doing this, some really old bugs and code improvements long
> overdue is in the series, much appreciated.
>
> Yours,
> Linus Walleij
>

Thanks for the comprehensive review! I'm glad this all makes some sense
and I'm not crazy about the approach :)

I'll wait a bit for any other feedback that might come in and then
submit a v2 with the fixes/changes mentioned so far.

Cheers,
--
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub