Re: [PATCH RFT] ieee802154: atusb: move to new USB API

From: Alexander Aring
Date: Sun Jan 02 2022 - 17:16:00 EST


Hi,

On Sun, 2 Jan 2022 at 12:19, Pavel Skripkin <paskripkin@xxxxxxxxx> wrote:
>
> Alexander reported a use of uninitialized value in
> atusb_set_extended_addr(), that is caused by reading 0 bytes via
> usb_control_msg().
>

Does there exist no way to check on this and return an error on USB
API caller level?

> Since there is an API, that cannot read less bytes, than was requested,
> let's move atusb driver to use it. It will fix all potintial bugs with
> uninit values and make code more modern
>

If this is not possible to fix with the "old" USB API then I think the
"old" USB API needs to be fixed.
Changing to the new USB API as "making the code more modern" is a new
feature and is a candidate for next.

- Alex