Re: [PATCH 21/34] brcmfmac: chip: Only disable D11 cores; handle an arbitrary number

From: Linus Walleij
Date: Sun Jan 02 2022 - 01:03:31 EST


On Sun, Dec 26, 2021 at 4:39 PM Hector Martin <marcan@xxxxxxxxx> wrote:

> At least on BCM4387, the D11 cores are held in reset on cold startup and
> firmware expects to release reset itself. Just assert reset here and let
> firmware deassert it. Premature deassertion results in the firmware
> failing to initialize properly some of the time, with strange AXI bus
> errors.
>
> Also, BCM4387 has 3 cores, up from 2. The logic for handling that is in
> brcmf_chip_ai_resetcore(), but since we aren't using that any more, just
> handle it here.
>
> Signed-off-by: Hector Martin <marcan@xxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij